Last week I had a good time with code review, all the guys who did coding are 3-4 years of experience in Microsoft technologies. But still there is scope for Optimization and best practice. Here in this blog post I’ll show you some of them.
1] A field can be made read-onlyConsider the following example, Admin_Settings class has a private object ObjDB (an object of class Database)
Code:Here, this object can be Readonly, by marking this readonly, we get to ensure that this class will not inadvertently modify this object anywhere within its methods.
Code:The same can be applied for Variables if they they are only being assigned in the constructor and offers to create an additional safeguard
2] Use 'var' keyword when initializer explicitly declares typeThe var keyword is fairly contentious in terms of usage, but if there’s one instance where its use is sensible, it’s in initializations alike to the following:
Code:Since the type is declared on both left and right-hand sides of the initialization statement, I suggest to remove the type on the left-hand side and replace it with var, i.e.:
Code:Or even further, you can remove redundant initializer and write it as
3] Use declaration closer to usage
Consider the following example, where many variables are declared which are not really closer to usage. The Database object DsPaidAmount is declared at the top, and used at the very bottom (so, declaration and usage are not closer).
Code:Here, we can move declaration closer to it’s usage, as follows:
Further, for better memory management we can use the “using” constructor, and also remove the type on the left-hand side and replace it with var as follows:
4] Remove unneeded 'else' keywordSome if-else conditions can have their else clause removed. Consider the following method:
Code:In the above, the else statement can be safely removed because its if clause returns from the method. Thus, even without the else, there’s no way you’ll be able to proceed past the if clause body. We can write it as follows:
Code:Even better; we can write it by converting it to “?:” operator
5] Join declaration and assignmentConsider the following example, where Type can use Implicitly typed local variable declaration and Join declaration and assignment
Code:Finally by removing redundant initalizer, using Implicitly typed local variable declaration, joining declaration and assignment and with a good naming convention for local variables, we can write this as follows:
6] Convert “IF” statements with “?:” operatorConsider the following example
Code:Can be written with pretty optimized version using “?:” operators as follows:
Code:Or even better by removing unneeded conditional ternary expression usage. Since condition returns a boolean value